Kiwix zim code#

The details are usually quite long, so they are controlled by the -details flag.

Error message in not useful to fix the ZIM file, the redundant article urls should be give.

You should avoid using 'i' during the hash computation and store 'it' instead.

Oh, and the hash algorithm I used is optimized for speed, so it has quite a bit of collisions. What do you mean by hash of listВ ?(did you mean list of hashes?).Same for hash of hash.

Why not using a hash of hash (instead of a hash of list) to store the hash keys, would be a lot easier to detect duplicates (no sort, no loop for the duplicate detection).

Output an info message to all successful checks.

Error messages should be more explicit, for example 'Favivon not found in ZIM file' should be 'Favivon not found in ZIM file, '/-/favicon' must exist.'.

It can be switched on by the -progress flag. The progress bar is now switched off by default.

Remove progress bar '#', or if you really want to see a progression print a new line each XВ %.

Kiwix zim code#

Strange 'unknown mime type code 65535' error code on the output.

argument parsing seems to be good, but way to store the result is not efficient use a bit array and constants to store the list of checks to do.Дo we need this? I mean, the current system is easier to understand.

methods name should be for example getLinks() instead of get_links().

Same for variable names, 'arr' is really a bad name for an array.Дone, please mention if you find anything else.

methods names are not well named ('get_links2' is unclear).

Zimcheck.cpp was split into 3 different files.

zimcheck.cpp is too long, should be split.

methodsare too long, code should be factorized.

This notion exists only in code comments, and even there, the names of the tests are given along with. should be abandoned everywhere (code&output).

Indentation is good, but lack of spaces in the code, in particular around the operators.

Multiple small typography issue (for example, never a space before a comma).

Explanation are always welcome, but usage() should be short.

Launch without argument should print the usage().

Error messages in case of bad arguments are unclear (what does 'Unknown option `115'' mean?)ДЇixed- BTW, 115 was the ASCII code of the bad argument.

Non perfect command line error handling.

Thank you!- Qgil ( talk) 18:02, 24 June 2013 (UTC) Tech feedback after 3 weeks zimcheck If you can't make it's fine, but let me know as well. Please confirm at qgil so I can add you to the calendar invitation and I have your preferred email for other occasions. We have done our best finding a time that works decently in as many timezones as possibles.

Hi, you are invited to the GSoC / OPW IRC AllHands meeting on Wednesday, Jat 15:00 UTC (8:30pm IST, 8am PDT). Is it fineВ ? Kiran mathew 1993 ( talk) 12:09, 23 June 2013 (UTC) GSoC / OPW IRC AllHands this week Thank you!- Qgil ( talk) 20:48, 19 June 2013 (UTC) Hi, I just came across this today, but I had edited the draft page for the post days ago. Hi, I'm drafting a blog post about GSoC and it would be helpful to know a bit more about you through your user profile, if you don't mind. Jwild ( talk) 15:49, (UTC) Thanks, I have started the work, and I expect a very exciting summer Kiran mathew 1993 ( talk) 11:38, 4 June 2013 (UTC) Longer intro, please? Your project is very exciting! Congratulations, and I am looking forward to seeing the work that comes out of it. Please join the Wikimedia India mailing list so you can keep up with what's happening in the Indian Wikimedia community! Sharihareswara (WMF) ( talk) 15:15, (UTC) Congratulations and welcome! Nemo 12:32, (UTC) ДЄre you already in the Indian Wikimedia community? I've followed Kiwix for a few years now and this is the feature that everyone keeps asking about ZIM and Wikimedia projects offline. Thanks for this proposal, I hope we can get this done.My exams will end on Saturday, so you can expect to see more activity from me from then on. My Exams are going on, I'll finish it in a couple of days. I won't be watching this talkpage for response - if you need help, please ask the chat channel ( IRC) or the mailing list. You're running out of time to apply for Google Summer of Code 2013 with Wikimedia! Please see Where to start. 3 Are you already in the Indian Wikimedia community?.